How we review code
"We review code to verify logic, catch edge cases, and prevent latency spikes, leaving formatting to compilers."
Hammad MajidWhy this exists
Code review is the final barrier before deployment. Biome automatically handles formatting and syntax style. This frees us to focus on data model safety, performance regressions, and query optimization.
Operational Flow
Local checks: Run linters, type checks, and tests locally before opening a pull request.
Database safety: Verify that schema changes do not lock active production tables or delete data.
Edge audit: Inspect environment variables and transaction boundaries in Cloudflare Workers.
Diff readability: Read your own diff first to ensure another developer can follow the logic.
Verification: Merge changes, then confirm stability on staging before deploying to production.
What good looks like
- An engineer reviews and responds to a pull request within four hours.
- Comments address performance defects, such as a query that will trigger an N+1 database call.
- The pull request description explains why you chose this implementation and details the tradeoffs.
What NOT to do
- Do not comment on indentation, spacing, or brace placement. Biome handles style.
- Do not approve a migration pull request without viewing the query plan first.
- Do not leave a colleague's pull request waiting for a review for more than half a day.
Code reviews are a collaborative check for correctness, not a platform for personal style preferences. Keep comments brief, technical, and actionable. Write code that is easy to read, and keep ego out of the pull request.