How we review code
"Our quality standards for review, ensuring performant, correct code without style arguments."
Why this exists
Code reviews are Kryft's final gate before code touches production. We use automated tooling (Biome) to enforce style, leaving reviews focused purely on correctness, edge cases, and safety.
Operational Flow
Local Checks: Run local linters, type checks, and tests before creating the PR.
Migration Verification: Ensure database changes are non-destructive and backward-compatible.
Edge Optimization: Audit Workers environment variables and transactional operations.
Readability Review: Read the diff to ensure it can be understood by other engineers.
Deploy: Merge and verify in the staging environment before production cutover.
What good looks like
- PR reviews are picked up and completed within 4 hours.
- Comments are focused on correctness, memory use, or latency anomalies.
- PR descriptions outline what is changing and why the approach was chosen.
What NOT to do
- Do not comment on code formatting (the Biome compiler handles this).
- Do not approve code if you haven't reviewed the database query plan.
- Do not let PRs sit unreviewed for more than half a working day.
A code review is a collaborative safety check, not a personal critique. We expect comments to be brief, correct, and actionable. Ego has no place in the pull request flow.